Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set KEP 1860 as implementable #2134

Merged
merged 4 commits into from
Nov 13, 2020
Merged

Set KEP 1860 as implementable #2134

merged 4 commits into from
Nov 13, 2020

Conversation

Sh4d1
Copy link
Member

@Sh4d1 Sh4d1 commented Nov 7, 2020 •
edited
Loading

Signed-off-by: Patrik Cyvoct [email protected]

Since kubernetes/kubernetes#92312 is merged, this KEP should be updated

Ref #1860

@Sh4d1
Copy link
Member Author

Sh4d1 commented Nov 7, 2020

/cc @thockin

@k8s-ci-robot k8s-ci-robot requested a review from thockin November 7, 2020 10:00
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 7, 2020
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/network Categorizes an issue or PR as relevant to SIG Network. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 7, 2020
Sh4d1 added 2 commits November 7, 2020 11:03
@Sh4d1
fix toc
70fd12e 
Signed-off-by: Patrik Cyvoct <[email protected]>
@Sh4d1
set to implemented
a6f7576 
Signed-off-by: Patrik Cyvoct <[email protected]>
@Sh4d1 Sh4d1 changed the title Propose KEP 1860 as implementable Propose KEP 1860 as implemented Nov 9, 2020
@Sh4d1 Sh4d1 changed the title Propose KEP 1860 as implemented Set KEP 1860 as implemented Nov 9, 2020
@Sh4d1 Sh4d1 mentioned this pull request Nov 10, 2020
Merged
@Sh4d1
set to implementable
0e987cd 
Signed-off-by: Patrik Cyvoct <[email protected]>
@Sh4d1 Sh4d1 changed the title Set KEP 1860 as implemented Set KEP 1860 as implementable Nov 11, 2020
@Sh4d1 Sh4d1 mentioned this pull request Nov 11, 2020
Open
12 tasks
thockin
thockin reviewed Nov 13, 2020
View reviewed changes
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Sh4d1, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 13, 2020
@k8s-ci-robot k8s-ci-robot merged commit 6960cc8 into kubernetes:master Nov 13, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thockin thockin thockin left review comments

@caseydavenport caseydavenport Awaiting requested review from caseydavenport

Assignees

@thockin thockin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/network Categorizes an issue or PR as relevant to SIG Network. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.
3 participants
@Sh4d1 @k8s-ci-robot @thockin